GitHub
2014-10-22 21:25:06 UTC
Branch: refs/heads/fix-TCP
Home: https://github.com/supercollider/supercollider
Commit: 58389da84b570863d08e4dc02ddda9ce17a99dd2
https://github.com/supercollider/supercollider/commit/58389da84b570863d08e4dc02ddda9ce17a99dd2
Author: Scott Wilson <***@scottwilson.ca>
Date: 2014-10-22 (Wed, 22 Oct 2014)
Changed paths:
M lang/LangPrimSource/OSCData.cpp
M lang/LangPrimSource/SC_ComPort.cpp
Log Message:
-----------
lang: Fix TCP bugs
This fixes Issue #1099. The problem was to do with the way in which incoming TCP messages were constructed before passing to the lang:
- The remote port info was not being set at all, and was then being converted from network to host order in ConvertReplyAddress. This was not needed as boost::asio::ip always gives ports in host order. UDP only worked because port was converted to network order and then back in ConvertReplyAddress, so that was removed as well.
- The received on port was being set to the remote port, so that was also corrected.
Home: https://github.com/supercollider/supercollider
Commit: 58389da84b570863d08e4dc02ddda9ce17a99dd2
https://github.com/supercollider/supercollider/commit/58389da84b570863d08e4dc02ddda9ce17a99dd2
Author: Scott Wilson <***@scottwilson.ca>
Date: 2014-10-22 (Wed, 22 Oct 2014)
Changed paths:
M lang/LangPrimSource/OSCData.cpp
M lang/LangPrimSource/SC_ComPort.cpp
Log Message:
-----------
lang: Fix TCP bugs
This fixes Issue #1099. The problem was to do with the way in which incoming TCP messages were constructed before passing to the lang:
- The remote port info was not being set at all, and was then being converted from network to host order in ConvertReplyAddress. This was not needed as boost::asio::ip always gives ports in host order. UDP only worked because port was converted to network order and then back in ConvertReplyAddress, so that was removed as well.
- The received on port was being set to the remote port, so that was also corrected.